On 01/09/2025 22:31, Brahmajit Das wrote:
Variable idx is set in the loop, but is never used resulting in dead
code. Building with GCC 16, which enables
-Werror=unused-but-set-parameter= by default results in build error.
This patch removes the dead code and fixes the build error.
Signed-off-by: Brahmajit Das <[email protected]>
---
drivers/net/ethernet/intel/fm10k/fm10k_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_common.c
b/drivers/net/ethernet/intel/fm10k/fm10k_common.c
index f51a63fca513..2fcbbd5accc2 100644
--- a/drivers/net/ethernet/intel/fm10k/fm10k_common.c
+++ b/drivers/net/ethernet/intel/fm10k/fm10k_common.c
@@ -457,7 +457,7 @@ void fm10k_unbind_hw_stats_q(struct fm10k_hw_stats_q *q,
u32 idx, u32 count)
{
u32 i;
- for (i = 0; i < count; i++, idx++, q++) {
+ for (i = 0; i < count; i++, q++) {
q->rx_stats_idx = 0;
q->tx_stats_idx = 0;
}
All callers to this function provide constant 0 as idx param. The better
solution would be to remove the parameter completely.
