Hi Jacob,

Thanks for the review.

It’s indeed an easy change. I’m wondering why untrusted VFs were originally limited to 16+2 MACs, and if changing this (overwriting that behavior) could be risky.

Anyway, I applied your suggestions in v3.

On 9/3/25 11:11 PM, Jacob Keller wrote:


On 9/3/2025 12:02 PM, [email protected] wrote:
From: Mohammad Heib <[email protected]>

Add a new device generic parameter to controls the maximum
number of MAC filters allowed per VF.

While this parameter is named `max_mac_per_vf`, the exact enforcement
policy may vary between drivers. For example, i40e applies this limit
only to trusted VFs, whereas other drivers may choose to apply it
uniformly across all VFs. The goal is to provide a consistent devlink
interface, while allowing flexibility for driver-specific behavior.


Would it make more sense to apply the limit to all VFs if set, and apply
the default variable behavior for when its unset? This would avoid the
need to have this much flexibility and latitude for each driver.

It seems like that wouldn't be too difficult.

Reply via email to