> -----Original Message-----
> From: Intel-wired-lan <[email protected]> On Behalf Of
> Simon Horman
> Sent: Wednesday, August 27, 2025 7:20 AM
> To: Tantilov, Emil S <[email protected]>
> Cc: [email protected]; [email protected]; Loktionov,
> Aleksandr <[email protected]>; Kitszel, Przemyslaw
> <[email protected]>; Nguyen, Anthony L
> <[email protected]>; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected]; Hay, Joshua
> A <[email protected]>; Chittim, Madhu <[email protected]>
> Subject: Re: [Intel-wired-lan] [PATCH iwl-net 2/2] idpf: fix possible race in
> idpf_vport_stop()
>
> On Thu, Aug 21, 2025 at 08:52:48PM -0700, Emil Tantilov wrote:
> > Make sure to clear the IDPF_VPORT_UP bit on entry. The
> > idpf_vport_stop() function is void and once called, the vport teardown
> > is guaranteed to happen. Previously the bit was cleared at the end of
> > the function, which opened it up to possible races with all instances
> > in the driver where operations were conditional on this bit being set.
> > For example, on rmmod callbacks in the middle of idpf_vport_stop() end
> > up attempting to remove MAC address filter already removed by the
> function:
> > idpf 0000:83:00.0: Received invalid MAC filter payload (op 536) (len
> > 0)
> >
> > Fixes: 1c325aac10a8 ("idpf: configure resources for TX queues")
> > Reviewed-by: Przemek Kitszel <[email protected]>
> > Reviewed-by: Aleksandr Loktionov <[email protected]>
> > Reviewed-by Joshua Hay <[email protected]>
> > Reviewed-by: Chittim Madhu <[email protected]>
> > Signed-off-by: Emil Tantilov <[email protected]>
>
> Reviewed-by: Simon Horman <[email protected]>
Tested-by: Samuel Salin <[email protected]>
