IEEE 802.3ck-2022 defines counters for FEC bins and 802.3df-2024
clarifies it a bit further. Implement reporting interface through as
addition to FEC stats available in ethtool. NetDevSim driver has simple
implementation as an example while mlx5 has much more complex solution.
The example query is the same as usual FEC statistics while the answer
is a bit more verbose:
[vmuser@archvm9 linux]$ ./tools/net/ynl/pyynl/cli.py --spec
Documentation/netlink/specs/ethtool.yaml --do fec-get --json
'{"header":{"dev-index": 10, "flags": 4}}'
{'auto': 0,
'header': {'dev-index': 10, 'dev-name': 'eni10np1'},
'modes': {'bits': {}, 'nomask': True, 'size': 121},
'stats': {'corr-bits': [],
'corrected': [123],
'hist': [{'bin-high': 0,
'bin-low': 0,
'bin-val': 445,
'bin-val-per-lane': [125, 120, 100, 100]},
{'bin-high': 3, 'bin-low': 1, 'bin-val': 12},
{'bin-high': 7, 'bin-low': 4, 'bin-val': 2}],
'uncorr': [4]}}
v1 -> v2:
* fix memset size of FEC histogramm bins in mlx5
* adjust fbnic driver FEC stats callback
Links to RFC discussions:
v1 - https://lore.kernel.org/netdev/[email protected]/
v2 - https://lore.kernel.org/netdev/[email protected]/
v3 - https://lore.kernel.org/netdev/[email protected]/
v4 - https://lore.kernel.org/netdev/[email protected]/
v5 - https://lore.kernel.org/netdev/[email protected]/
Carolina Jubran (3):
net/mlx5e: Don't query FEC statistics when FEC is disabled
net/mlx5e: Add logic to read RS-FEC histogram bin ranges from PPHCR
net/mlx5e: Report RS-FEC histogram statistics via ethtool
Vadim Fedorenko (1):
ethtool: add FEC bins histogramm report
Documentation/netlink/specs/ethtool.yaml | 22 ++++
Documentation/networking/ethtool-netlink.rst | 5 +
.../net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 3 +-
.../ethernet/fungible/funeth/funeth_ethtool.c | 3 +-
.../ethernet/hisilicon/hns3/hns3_ethtool.c | 3 +-
drivers/net/ethernet/intel/ice/ice_ethtool.c | 4 +-
.../marvell/octeontx2/nic/otx2_ethtool.c | 3 +-
drivers/net/ethernet/mellanox/mlx5/core/en.h | 1 +
.../ethernet/mellanox/mlx5/core/en_ethtool.c | 5 +-
.../net/ethernet/mellanox/mlx5/core/en_main.c | 10 ++
.../ethernet/mellanox/mlx5/core/en_stats.c | 102 ++++++++++++++++--
.../ethernet/mellanox/mlx5/core/en_stats.h | 4 +-
.../net/ethernet/meta/fbnic/fbnic_ethtool.c | 3 +-
drivers/net/ethernet/sfc/ethtool.c | 3 +-
drivers/net/ethernet/sfc/siena/ethtool.c | 3 +-
drivers/net/netdevsim/ethtool.c | 22 +++-
include/linux/ethtool.h | 25 ++++-
.../uapi/linux/ethtool_netlink_generated.h | 11 ++
net/ethtool/fec.c | 69 +++++++++++-
19 files changed, 278 insertions(+), 23 deletions(-)
--
2.47.3
