On 9/11/2025 9:36 AM, Loktionov, Aleksandr wrote:
-----Original Message-----
From: Kohei Enju <[email protected]>
Sent: Wednesday, September 10, 2025 3:47 PM
To: [email protected]; [email protected]
Cc: Nguyen, Anthony L <[email protected]>; Kitszel,
Przemyslaw <[email protected]>; Andrew Lunn
<[email protected]>; David S. Miller <[email protected]>; Eric
Dumazet <[email protected]>; Jakub Kicinski <[email protected]>; Paolo
Abeni <[email protected]>; Kurt Kanzenbach <[email protected]>;
Loktionov, Aleksandr <[email protected]>; Lifshits, Vitaly
<[email protected]>; [email protected]; Kohei Enju
<[email protected]>
Subject: [PATCH v2 iwl-net] igc: don't fail igc_probe() on LED setup
error
...
FAILSLAB_PATH=/sys/kernel/debug/failslab/
DEVICE=0000:00:05.0
START_ADDR=$(grep " igc_led_setup" /proc/kallsyms \
| awk '{printf("0x%s", $1)}')
END_ADDR=$(printf "0x%x" $((START_ADDR + 0x100)))
echo $START_ADDR > $FAILSLAB_PATH/require-start
echo $END_ADDR > $FAILSLAB_PATH/require-end
echo 1 > $FAILSLAB_PATH/times
echo 100 > $FAILSLAB_PATH/probability
echo N > $FAILSLAB_PATH/ignore-gfp-wait
echo $DEVICE > /sys/bus/pci/drivers/igc/bind
Using fault-injection test using failslab - excellent!
Fixes: ea578703b03d ("igc: Add support for LEDs on i225/i226")
Signed-off-by: Kohei Enju <[email protected]>
---
Changes:
v1->v2:
- don't fail probe when led setup fails
- rephrase subject and commit message
v1: https://lore.kernel.org/intel-wired-lan/20250906055239.29396-1-
[email protected]/
---
...
/* Release control of h/w to f/w. If f/w is AMT enabled, this
--
2.48.1
Reviewed-by: Aleksandr Loktionov <[email protected]>
Reviewed-by: Vitaly Lifshits <[email protected]>
