> -----Original Message-----
> From: Intel-wired-lan <[email protected]> On Behalf
> Of Przemek Kitszel
> Sent: Friday, September 12, 2025 3:06 PM
> To: [email protected]; Nguyen, Anthony L
> <[email protected]>
> Cc: [email protected]; Simon Horman <[email protected]>; Kitszel,
> Przemyslaw <[email protected]>; Keller, Jacob E
> <[email protected]>
> Subject: [Intel-wired-lan] [PATCH iwl-next 8/9] ice: move
> ice_deinit_dev() to the end of deinit paths
>
> ice_deinit_dev() takes care of turning off adminq processing, which is
> much needed during driver teardown (remove, reset, error path). Move
> it to the very end where applicable.
> For example, ice_deinit_hw() called after adminq deinit slows rmmod on
> my two-card setup by about 60 seconds.
>
> ice_init_dev() and ice_deinit_dev() scopes were reduced by previous
> commits of the series, with a final touch of extracting
> ice_init_dev_hw() out now (there is no deinit counterpart).
>
> Note that removed ice_service_task_stop() call from ice_remove() is
> placed in the ice_deinit_dev() (and stopping twice makes no sense).
>
> Signed-off-by: Przemek Kitszel <[email protected]>
> ---
...
> /**
> --
> 2.39.3
Reviewed-by: Aleksandr Loktionov <[email protected]>
