On 9/13/25 01:19, Jakub Kicinski wrote:
On Fri, 12 Sep 2025 15:06:20 +0200 Przemek Kitszel wrote:
+ timer_setup(&pf->serv_tmr, ice_service_timer, 0);
+ pf->serv_tmr_period = HZ;
+ INIT_WORK(&pf->serv_task, ice_service_task);
+ clear_bit(ICE_SERVICE_SCHED, pf->state);
I should just read the code, but this looks like an open-coded
deferred_work ?
I wanted to put some joke about our driver, but it is not funny :F
ice-service-task is scheduled both by the timer and work_queue (ice_wq),
there is more flags that I could count around the scheduling, and it is
a pain to stop/reset the thing - I will definitively try to simplify
the thing (esp. given I have a bug with driver reset on me)
but for now, the cited thing is just a little chunk that I have moved
from one function to another (and the whole series is not about a race)
