> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf > Of Jacob Keller > Sent: Tuesday, September 16, 2025 10:09 PM > To: Nguyen, Anthony L <[email protected]>; Kitszel, > Przemyslaw <[email protected]>; Lobakin, Aleksander > <[email protected]>; Andrew Lunn <[email protected]>; > David S. Miller <[email protected]>; Eric Dumazet > <[email protected]>; Jakub Kicinski <[email protected]>; Paolo Abeni > <[email protected]>; Michal Swiatkowski > <[email protected]> > Cc: [email protected]; [email protected]; linux- > [email protected]; Keller, Jacob E <[email protected]> > Subject: [Intel-wired-lan] [PATCH iwl-net] libie: fix string names for > AQ error codes > > The LIBIE_AQ_STR macro() introduced by commit 5feaa7a07b85 ("libie: > add adminq helper for converting err to str") is used in order to > generate strings for printing human readable error codes. Its > definition is missing the separating underscore ('_') character which > makes the resulting strings difficult to read. Additionally, the > string won't match the source code, preventing search tools from > working properly. > > Add the missing underscore character, fixing the error string names. > > Signed-off-by: Jacob Keller <[email protected]> > Fixes: 5feaa7a07b85 ("libie: add adminq helper for converting err to > str") > --- > I found this recently while reviewing the libie code. I believe this > warrants a net fix because it is both simple, and because users may > attempt to pass printed error codes into search tools like grep, and > will be unable to locate the error values without manually adding the > missing '_'. > --- > drivers/net/ethernet/intel/libie/adminq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/intel/libie/adminq.c > b/drivers/net/ethernet/intel/libie/adminq.c > index 55356548e3f0..7b4ff479e7e5 100644 > --- a/drivers/net/ethernet/intel/libie/adminq.c > +++ b/drivers/net/ethernet/intel/libie/adminq.c > @@ -6,7 +6,7 @@ > > static const char * const libie_aq_str_arr[] = { > #define LIBIE_AQ_STR(x) \ > - [LIBIE_AQ_RC_##x] = "LIBIE_AQ_RC" #x > + [LIBIE_AQ_RC_##x] = "LIBIE_AQ_RC_" #x > LIBIE_AQ_STR(OK), > LIBIE_AQ_STR(EPERM), > LIBIE_AQ_STR(ENOENT), > > --- > base-commit: 93ab4881a4e2b9657bdce4b8940073bfb4ed5eab > change-id: 20250916-jk-fix-missing-underscore-e2ffc7e39438 > > Best regards, > -- > Jacob Keller <[email protected]>
Reviewed-by: Aleksandr Loktionov <[email protected]>
