On 10/14/2025 7:11 AM, Michal Swiatkowski wrote:
> Building the ixgbe without CONFIG_DEBUG_FS leads to a build error. Fix
> that by guarding fwlog code.
>
> Fixes: 641585bc978e ("ixgbe: fwlog support for e610")
> Reported-by: Guenter Roeck <[email protected]>
> Closes:
> https://lore.kernel.org/lkml/[email protected]/
> Signed-off-by: Michal Swiatkowski <[email protected]>
> ---
Hm. It probably is best to make this optional and not require debugfs
via kconfig.
> drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c | 2 ++
> drivers/net/ethernet/intel/ixgbe/ixgbe_e610.h | 8 ++++++++
> 2 files changed, 10 insertions(+)
>
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c
> b/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c
> index c2f8189a0738..c5d76222df18 100644
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c
> @@ -3921,6 +3921,7 @@ static int ixgbe_read_pba_string_e610(struct ixgbe_hw
> *hw, u8 *pba_num,
> return err;
> }
>
> +#ifdef CONFIG_DEBUG_FS
> static int __fwlog_send_cmd(void *priv, struct libie_aq_desc *desc, void
> *buf,
> u16 size)
> {
> @@ -3952,6 +3953,7 @@ void ixgbe_fwlog_deinit(struct ixgbe_hw *hw)
>
> libie_fwlog_deinit(&hw->fwlog);
> }
> +#endif /* CONFIG_DEBUG_FS */
>
What does the fwlog module from libie do? Seems likely that it won't
compile without CONFIG_DEBUG_FS either...
> static const struct ixgbe_mac_operations mac_ops_e610 = {
> .init_hw = ixgbe_init_hw_generic,
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.h
> b/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.h
> index 11916b979d28..5317798b3263 100644
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.h
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_e610.h
> @@ -96,7 +96,15 @@ int ixgbe_aci_update_nvm(struct ixgbe_hw *hw, u16
> module_typeid,
> bool last_command, u8 command_flags);
> int ixgbe_nvm_write_activate(struct ixgbe_hw *hw, u16 cmd_flags,
> u8 *response_flags);
> +#ifdef CONFIG_DEBUG_FS
> int ixgbe_fwlog_init(struct ixgbe_hw *hw);
> void ixgbe_fwlog_deinit(struct ixgbe_hw *hw);
> +#else
> +static inline int ixgbe_fwlog_init(struct ixgbe_hw *hw)
> +{
> + return -EOPNOTSUPP;
> +}
> +static inline void ixgbe_fwlog_deinit(struct ixgbe_hw *hw) {}
> +#endif /* CONFIG_DEBUG_FS */
>
> #endif /* _IXGBE_E610_H_ */
OpenPGP_signature.asc
Description: OpenPGP digital signature
