> -----Original Message-----
> From: Intel-wired-lan <[email protected]> On Behalf
> Of Kohei Enju
> Sent: Monday, October 6, 2025 2:35 PM
> To: [email protected]; [email protected]
> Cc: Nguyen, Anthony L <[email protected]>; Kitszel,
> Przemyslaw <[email protected]>; Andrew Lunn
> <[email protected]>; David S. Miller <[email protected]>; Eric
> Dumazet <[email protected]>; Jakub Kicinski <[email protected]>; Paolo
> Abeni <[email protected]>; Auke Kok <[email protected]>; Jeff
> Garzik <[email protected]>; Sasha Neftin <[email protected]>;
> Richard Cochran <[email protected]>; Keller, Jacob E
> <[email protected]>; [email protected]; Kohei Enju
> <[email protected]>
> Subject: [Intel-wired-lan] [PATCH iwl-net v1 1/3] igb: use EOPNOTSUPP
> instead of ENOTSUPP in igb_get_sset_count()
> 
> igb_get_sset_count() returns -ENOTSUPP when a given stringset is not
> supported, causing userland programs to get "Unknown error 524".
> 
> Since EOPNOTSUPP should be used when error is propagated to userland,
> return -EOPNOTSUPP instead of -ENOTSUPP.
> 
> Fixes: 9d5c824399de ("igb: PCI-Express 82575 Gigabit Ethernet driver")
> Signed-off-by: Kohei Enju <[email protected]>
> ---
>  drivers/net/ethernet/intel/igb/igb_ethtool.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c
> b/drivers/net/ethernet/intel/igb/igb_ethtool.c
> index f8a208c84f15..10e2445e0ded 100644
> --- a/drivers/net/ethernet/intel/igb/igb_ethtool.c
> +++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c
> @@ -2281,7 +2281,7 @@ static int igb_get_sset_count(struct net_device
> *netdev, int sset)
>       case ETH_SS_PRIV_FLAGS:
>               return IGB_PRIV_FLAGS_STR_LEN;
>       default:
> -             return -ENOTSUPP;
> +             return -EOPNOTSUPP;
>       }
>  }
> 
> --
> 2.48.1

Reviewed-by: Aleksandr Loktionov <[email protected]>

Reply via email to