> -----Original Message-----
> From: Keller, Jacob E <[email protected]>
> Sent: Thursday, October 23, 2025 12:48 AM
> To: Loktionov, Aleksandr <[email protected]>; intel-wired-
> [email protected]; [email protected]; Nguyen, Anthony L
> <[email protected]>
> Subject: Re: [PATCH iwl-next v6 3/6] ice: implement GTP RSS context
> tracking and configuration
>
>
>
> On 10/22/2025 6:12 AM, Aleksandr Loktionov wrote:
> > +static enum virtchnl_status_code
> > +ice_vc_rss_hash_update(struct ice_hw *hw, struct ice_vsi *vsi, u8
> > +hash_type) {
>
> This was explicitly called out in the version we sent to netdev last
> week as being too similar to ice_status.
>
> Can you refactor this to use integer error codes, and convert to a
> status value only right before we generate the command to send to
> virtchnl?
>
> Checking against current ice driver, only one other function appears
> to directly return a status code. We have ice_err_to_vert_err and
> ice_virt_err_to_err() which are referred over passing around these
> virtchnl status codes more than necessary.
Good day Jacob
I don't know the long history of virtchnl_status_code in upstream virt/rss.c
Now I see from the second glance that even internal VC functions return in.
Thank you
Alex
