> -----Original Message-----
> From: Intel-wired-lan <[email protected]> On Behalf
> Of Alok Tiwari
> Sent: Friday, October 24, 2025 8:25 PM
> To: Lobakin, Aleksander <[email protected]>; Nguyen,
> Anthony L <[email protected]>; Kitszel, Przemyslaw
> <[email protected]>; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]
> Cc: [email protected]; [email protected]
> Subject: [Intel-wired-lan] [PATCH net-next v3] idpf: correct queue
> index in Rx allocation error messages
> 
> The error messages in idpf_rx_desc_alloc_all() used the group index i
> when reporting memory allocation failures for individual Rx and Rx
> buffer queues. This is incorrect.
> 
> Update the messages to use the correct queue index j and include the
> queue group index i for clearer identification of the affected Rx and
> Rx buffer queues.
> 
> Signed-off-by: Alok Tiwari <[email protected]>
> Reviewed-by: Simon Horman <[email protected]>
> ---
> v1 -> v2
> no change added Reviewed-by: Simon
> v2 -> v3
> added queue group index i as suggested by Alexander.
> ---
>  drivers/net/ethernet/intel/idpf/idpf_txrx.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/idpf/idpf_txrx.c
> b/drivers/net/ethernet/intel/idpf/idpf_txrx.c
> index 828f7c444d30..ed0383ab5979 100644
> --- a/drivers/net/ethernet/intel/idpf/idpf_txrx.c
> +++ b/drivers/net/ethernet/intel/idpf/idpf_txrx.c
> @@ -922,8 +922,8 @@ static int idpf_rx_desc_alloc_all(struct
> idpf_vport *vport)
>                       err = idpf_rx_desc_alloc(vport, q);
>                       if (err) {
>                               pci_err(vport->adapter->pdev,
> -                                     "Memory allocation for Rx Queue %u
> failed\n",
> -                                     i);
> +                                     "Memory allocation for Rx queue %u
> from queue group %u failed\n",
> +                                     j, i);
>                               goto err_out;
>                       }
>               }
> @@ -939,8 +939,8 @@ static int idpf_rx_desc_alloc_all(struct
> idpf_vport *vport)
>                       err = idpf_bufq_desc_alloc(vport, q);
>                       if (err) {
>                               pci_err(vport->adapter->pdev,
> -                                     "Memory allocation for Rx Buffer
> Queue %u failed\n",
> -                                     i);
> +                                     "Memory allocation for Rx Buffer
> Queue %u from queue group %u failed\n",
> +                                     j, i);
>                               goto err_out;
>                       }
>               }
> --
> 2.50.1

Reviewed-by: Aleksandr Loktionov <[email protected]>

Reply via email to