> -----Original Message----- > From: Keller, Jacob E <[email protected]> > Sent: Wednesday, November 5, 2025 10:07 PM > To: Loktionov, Aleksandr <[email protected]>; Lobakin, > Aleksander <[email protected]>; Nguyen, Anthony L > <[email protected]>; Kitszel, Przemyslaw > <[email protected]> > Cc: [email protected]; [email protected]; Keller, > Jacob E <[email protected]> > Subject: [PATCH iwl-next v2 4/9] ice: move prev_pkt from ice_txq_stats > to ice_tx_ring > > The prev_pkt field in ice_txq_stats is used by > ice_check_for_hung_subtask as a way to detect potential Tx hangs due > to missed interrupts. > > The value is based on the packet count, but its an int and not really > a "statistic". The value is signed so that we can use -1 as a "no work > pending" value. A following change is going to refactor the stats to > all use the u64_stat_t type and accessor functions. Leaving prev_pkt > as the lone int feels a bit strange. > > Instead, move it out of ice_txq_stats and place it in the ice_tx_ring. > We have 8 bytes still available in the 3rd cacheline, so this move > saves a small amount of memory. It also shouldn't impact the Tx path > heavily since its only accessed during initialization and the hang > subtask. > > Signed-off-by: Jacob Keller <[email protected]> > ---
... > -- > 2.51.0.rc1.197.g6d975e95c9d7 Reviewed-by: Aleksandr Loktionov <[email protected]>
