On Thu, Nov 20, 2025 at 12:20:44PM -0800, Jacob Keller wrote: > The __ice_update_sample and __ice_get_ethtool_stats functions directly > accesses the pkts and bytes counters from the ring stats. A following > change is going to update the fields to be u64_stats_t type, and will need > to be accessed appropriately. This will ensure that the accesses do not > cause load/store tearing. > > Add helper functions similar to the ones used for updating the stats > values, and use them. This ensures use of the syncp pointer on 32-bit > architectures. Once the fields are updated to u64_stats_t, it will then > properly avoid tears on all architectures. > > Reviewed-by: Aleksandr Loktionov <[email protected]> > Signed-off-by: Jacob Keller <[email protected]>
This seems like a nice clean up to me. And I think it makes sense in the context of where this patch set is going. Reviewed-by: Simon Horman <[email protected]>
