On Wed, Nov 26, 2025 at 07:30:18AM +0100, Przemek Kitszel wrote: > On 11/24/25 18:42, Andy Shevchenko wrote: > > In many functions the Return section is missing. Fix kernel-doc > > descriptions to address that and other warnings. > > > > Before the change: > > > > $ scripts/kernel-doc -none -Wreturn > > drivers/net/ethernet/intel/idpf/idpf_txrx.c 2>&1 | wc -l > > 85
> this is small change and leaves the driver good for long future to come > I think it is net-positive in terms of minor annoyances for rebase or > backports, so: > Reviewed-by: Przemek Kitszel <[email protected]> Thank you! > side note: > Alex did analogous work for the ice driver, and I stopped him going > public, as it was counted in thousands lines changes for little benefit > > usual rant about kdoc warnings: > agghr!! (And usual rant about warnings in Linux Next unrelated to my code) Yes, the problem is that there are warnings and, if your tree is in Linux Next, make Stephen's and others lives easier by not having / producing new ones. So, please, send fixes for ice as well at some point. It can be just a single change (in case one wants to backport it). In _long term_ it's much better than (what is happening with ice case) increasing a technical debt. -- With Best Regards, Andy Shevchenko
