On 11/23/2025 11:40 PM, Ally Heev wrote:
Uninitialized pointers with `__free` attribute can cause undefined behavior as the memory assigned randomly to the pointer is freed automatically when the pointer goes out of scope. We could just fix it by initializing the pointer to NULL, but, as usage of cleanup attributes is discouraged in net [1], trying to achieve cleanup using goto
These two drivers already have multiple other usages of this. All the other instances initialize to NULL; I'd prefer to see this do the same over changing this single instance.
Thanks, Tony
[1] https://docs.kernel.org/process/maintainer-netdev.html#using-device-managed-and-cleanup-h-constructs Signed-off-by: Ally Heev <[email protected]> --- Ally Heev (2): ice: remove __free usage in ice_flow idpf: remove __free usage in idpf_virtchnl drivers/net/ethernet/intel/ice/ice_flow.c | 6 ++++-- drivers/net/ethernet/intel/idpf/idpf_virtchnl.c | 28 +++++++++++++++++-------- 2 files changed, 23 insertions(+), 11 deletions(-) --- base-commit: 24598358a1b4ca1d596b8e7b34a7bc76f54e630f change-id: 20251113-aheev-fix-free-uninitialized-ptrs-ethernet-intel-abc0cc9278d8 Best regards, -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQQBFRpOLrIakF7DYvaWPaLUP9d7HAUCaRn0WAAKCRCWPaLUP9d7 HPCSAP4tu8ld+4Og65tjSYNChRqIR4Gn8C546JFeozyQW6uj3wD/SQEPIidSAYbb klXrZrKIBOc/avt55S2+krl241aNJA8= =guHM -----END PGP SIGNATURE-----
