> -----Original Message-----
> From: Intel-wired-lan <[email protected]> On Behalf
> Of Takashi Kozu
> Sent: Friday, December 5, 2025 9:21 AM
> To: Nguyen, Anthony L <[email protected]>
> Cc: Kitszel, Przemyslaw <[email protected]>;
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; Takashi Kozu <[email protected]>; Kohei Enju
> <[email protected]>
> Subject: [Intel-wired-lan] [PATCH iwl-next v1 2/3] igb: expose RSS key
> via ethtool get_rxfh
>
> Implement igc_get_rxfh_key_size() and extend
> igc_get_rxfh() to return the RSS key to userspace.
>
> This can be tested using `ethtool -x <dev>`.
>
nit (commit message): s/igc_get_rxfh_key_size()/igb_get_rxfh_key_size()/;
s/igc_get_rxfh()/igb_get_rxfh()/.
The code implements igb_* symbols and wires them into igb_ethtool_ops, so the
message should match the actual driver.
With the best regards
Alex
> Tested-by: Kohei Enju <[email protected]>
> Signed-off-by: Takashi Kozu <[email protected]>
> ---
> drivers/net/ethernet/intel/igb/igb_ethtool.c | 16 ++++++++++++----
> 1 file changed, 12 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c
> b/drivers/net/ethernet/intel/igb/igb_ethtool.c
> index 8695ff28a7b8..2953d079ebae 100644
> --- a/drivers/net/ethernet/intel/igb/igb_ethtool.c
> +++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c
> @@ -3285,11 +3285,13 @@ static int igb_get_rxfh(struct net_device
> *netdev,
> int i;
>
> rxfh->hfunc = ETH_RSS_HASH_TOP;
> - if (!rxfh->indir)
> - return 0;
> - for (i = 0; i < IGB_RETA_SIZE; i++)
> - rxfh->indir[i] = adapter->rss_indir_tbl[i];
>
> + if (rxfh->indir)
> + for (i = 0; i < IGB_RETA_SIZE; i++)
> + rxfh->indir[i] = adapter->rss_indir_tbl[i];
> +
> + if (rxfh->key)
> + memcpy(rxfh->key, adapter->rss_key, sizeof(adapter-
> >rss_key));
> return 0;
> }
>
> @@ -3328,6 +3330,11 @@ void igb_write_rss_indir_tbl(struct igb_adapter
> *adapter)
> }
> }
>
> +static u32 igb_get_rxfh_key_size(struct net_device *netdev) {
> + return IGB_RSS_KEY_SIZE;
> +}
> +
> static int igb_set_rxfh(struct net_device *netdev,
> struct ethtool_rxfh_param *rxfh,
> struct netlink_ext_ack *extack)
> @@ -3491,6 +3498,7 @@ static const struct ethtool_ops igb_ethtool_ops
> = {
> .get_module_eeprom = igb_get_module_eeprom,
> .get_rxfh_indir_size = igb_get_rxfh_indir_size,
> .get_rxfh = igb_get_rxfh,
> + .get_rxfh_key_size = igb_get_rxfh_key_size,
> .set_rxfh = igb_set_rxfh,
> .get_rxfh_fields = igb_get_rxfh_fields,
> .set_rxfh_fields = igb_set_rxfh_fields,
> --
> 2.51.1
