> -----Original Message-----
> From: Intel-wired-lan <[email protected]> On Behalf
> Of [email protected]
> Sent: Wednesday, December 17, 2025 8:00 PM
> To: [email protected]
> Cc: Nguyen, Anthony L <[email protected]>; Kitszel,
> Przemyslaw <[email protected]>; [email protected];
> [email protected]; [email protected]; [email protected]; Keller,
> Jacob E <[email protected]>; Mohammad Heib <[email protected]>
> Subject: [Intel-wired-lan] [PATCH net 2/2] ice: drop
> udp_tunnel_get_rx_info() call from ndo_open()
>
> From: Mohammad Heib <[email protected]>
>
> The ice driver calls udp_tunnel_get_rx_info() during
> ice_open_internal().
> This is redundant because UDP tunnel RX offload state is preserved
> across device down/up cycles. The udp_tunnel core handles
> synchronization automatically when required.
>
> Furthermore, recent changes in the udp_tunnel infrastructure require
> querying RX info while holding the udp_tunnel lock. Calling it
> directly from the ndo_open path violates this requirement, triggering
> the lockdep warning.
>
> Remove the redundant and unsafe call to ice_open_internal() to resolve
I think it should be "Remove the redundant and unsafe call to
udp_tunnel_get_rx_info() from ice_open_internal()"?
> the locking violation.
>
Please add lockdep trace evidence in the commit message.
Reviewed-by: Aleksandr Loktionov <[email protected]>
> Fixes: a4e82a81f573 ("ice: Add support for tunnel offloads")
> Signed-off-by: Mohammad Heib <[email protected]>
> ---
> drivers/net/ethernet/intel/ice/ice_main.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_main.c
> b/drivers/net/ethernet/intel/ice/ice_main.c
> index 2533876f1a2f..1f94bdcbbba9 100644
> --- a/drivers/net/ethernet/intel/ice/ice_main.c
> +++ b/drivers/net/ethernet/intel/ice/ice_main.c
> @@ -9633,9 +9633,6 @@ int ice_open_internal(struct net_device *netdev)
> netdev_err(netdev, "Failed to open VSI 0x%04X on switch
> 0x%04X\n",
> vsi->vsi_num, vsi->vsw->sw_id);
>
> - /* Update existing tunnels information */
> - udp_tunnel_get_rx_info(netdev);
> -
> return err;
> }
>
> --
> 2.52.0
