> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of Jacob > Keller > Sent: 21 November 2025 01:51 > To: Loktionov, Aleksandr <[email protected]>; Lobakin, Aleksander > <[email protected]>; Nguyen, Anthony L > <[email protected]>; Kitszel, Przemyslaw > <[email protected]> > Cc: Simon Horman <[email protected]>; [email protected]; > [email protected]; Keller, Jacob E <[email protected]>; > Loktionov, Aleksandr <[email protected]> > Subject: [Intel-wired-lan] [PATCH iwl-next v4 2/6] ice: pass pointer to > ice_fetch_u64_stats_per_ring > > The ice_fetch_u64_stats_per_ring function takes a pointer to the syncp from > the ring stats to synchronize reading of the packet stats. It also takes a *copy* of the ice_q_stats fields instead of a pointer to the stats. This completely defeats the point of using the u64_stats API. We pass the stats by value, so they are static at the point of reading within the u64_stats_fetch_retry loop. > > Simplify the function to take a pointer to the ice_ring_stats instead of two > separate parameters. Additionally, since we never call this outside of > ice_main.c, make it a static function. > > Reviewed-by: Aleksandr Loktionov <[email protected]> > Signed-off-by: Jacob Keller <[email protected]> > --- > drivers/net/ethernet/intel/ice/ice.h | 3 --- > drivers/net/ethernet/intel/ice/ice_main.c | 24 +++++++++--------------- > 2 files changed, 9 insertions(+), 18 deletions(-) >
Tested-by: Rinitha S <[email protected]> (A Contingent worker at Intel)
