Hey Paul,
On 2026-01-13 11:31 PM, Paul Menzel wrote:
[Cc: +Michal]
Dear Dawid, dear Jakub,
...
Am 13.01.26 um 20:38 schrieb Dawid Osuchowski:
Ccing Michal, given they are the author of the "reverted" commit.
At least Michal was not in the (visible) Cc: list
Interesting. I was using 'git send-email' without any suppression of Cc
or similar options. In the direct email sent from me Michal is in Cc,
seems the mailing list for some reason stripped him...
drivers/net/ethernet/intel/ice/ice_common.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
...
do {
status = ice_sq_send_cmd(hw, cq, desc, buf, buf_size, cd);
if (!is_cmd_for_retry || !status ||
hw->adminq.sq_last_status != LIBIE_AQ_RC_EBUSY)
break;
+ if (buf_cpy)
+ memcpy(buf, buf_cpy, buf_size);
memcpy(desc, &desc_cpy, sizeof(desc_cpy));
-
Unrelated change?
During internal review it was pointed out that this function contains a
lot of empty lines, this was my feeble attempt to at least partially
reduce their count.
msleep(ICE_SQ_SEND_DELAY_TIME_MS);
} while (++idx < ICE_SQ_SEND_MAX_EXECUTE);
+ kfree(buf_cpy);
return status;
}
The diff looks good otherwise.
Reviewed-by: Paul Menzel <[email protected]>
Kind regards,
Paul
Thanks,
Dawid
