> -----Original Message-----
> From: Intel-wired-lan <[email protected]> On Behalf
> Of Thomas Gleixner
> Sent: Saturday, February 7, 2026 11:50 AM
> To: [email protected]
> Cc: Nguyen, Anthony L <[email protected]>; Kitszel,
> Przemyslaw <[email protected]>; [email protected]
> Subject: [Intel-wired-lan] i40e: Fix preempt count leak in napi poll
> tracepoint
> 
> Using get_cpu() in the tracepoint assignment causes an obvious preempt
> count leak because nothing invokes put_cpu() to undo it:
> 
>   softirq: huh, entered softirq 3 NET_RX with preempt_count 00000100,
> exited with 00000101?
> 
> This clearly has seen a lot of testing in the last 3+ years...
> 
> Use smp_processor_id() instead.
> 
> Fixes: 6d4d584a7ea8 ("i40e: Add i40e_napi_poll tracepoint")
> Signed-off-by: Thomas Gleixner <[email protected]>
> Cc: Tony Nguyen <[email protected]>
> Cc: Przemek Kitszel <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> ---
>  drivers/net/ethernet/intel/i40e/i40e_trace.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/drivers/net/ethernet/intel/i40e/i40e_trace.h
> +++ b/drivers/net/ethernet/intel/i40e/i40e_trace.h
> @@ -88,7 +88,7 @@ TRACE_EVENT(i40e_napi_poll,
>               __entry->rx_clean_complete = rx_clean_complete;
>               __entry->tx_clean_complete = tx_clean_complete;
>               __entry->irq_num = q->irq_num;
> -             __entry->curr_cpu = get_cpu();
> +             __entry->curr_cpu = smp_processor_id();
>               __assign_str(qname);
>               __assign_str(dev_name);
>               __assign_bitmask(irq_affinity, cpumask_bits(&q-
> >affinity_mask),

Reviewed-by: Aleksandr Loktionov <[email protected]>

Reply via email to