On Fri, Feb 13, 2026 at 04:02:53PM +0000, Loktionov, Aleksandr wrote: > > > > -----Original Message----- > > From: Simon Horman <[email protected]> > > Sent: Friday, February 13, 2026 4:14 PM > > To: Loktionov, Aleksandr <[email protected]> > > Cc: Simon Horman <[email protected]>; [email protected]; > > Jagielski, Jedrzej <[email protected]>; Nguyen, Anthony L > > <[email protected]>; [email protected]; > > [email protected] > > Subject: Re: [iwl-next,v3] ixgbe: fix unaligned u32 access in > > ixgbe_update_flash_X550() > > > > This is an AI-generated review of your patch. The human sending this > > email has considered the AI review valid, or at least plausible. > > > > For local reproduction steps see https://netdev-ai.bots.linux.dev/ai- > > local.html > > --- > > ixgbe: fix unaligned u32 access in ixgbe_update_flash_X550() > > > > This commit adds a u32 member to union ixgbe_hic_hdr2 to ensure 4-byte > > alignment on the stack, preventing unaligned 32-bit accesses when > > ixgbe_host_interface_command() treats the buffer as a u32 array. > > > > > ixgbe: fix unaligned u32 access in ixgbe_update_flash_X550() > > > > > > ixgbe_host_interface_command() treats its buffer as a u32 array. The > > > local buffer we pass in was a union of byte-sized fields, which > > gives > > > it 1-byte alignment on the stack. On strict-align architectures this > > > can cause unaligned 32-bit accesses. > > > > > > Add a u32 member to union ixgbe_hic_hdr2 so the object is 4-byte > > > aligned, and pass the u32 member when calling > > > ixgbe_host_interface_command(). > > > > > > No functional change on x86; prevents unaligned accesses on > > > architectures that enforce natural alignment. > > > > > > Fixes: 49425dfc7451 ("ixgbe: Add support for x550em_a 10G MAC type") > > > > Does this Fixes tag point to the correct commit? The alignment issue > > appears to have been introduced by commit 6a14ee0cfb19 ("ixgbe: Add > > X550 support function pointers") from 2014-12-05, which introduced > > both the union ixgbe_hic_hdr2 without a u32 member for proper > > alignment and the > > ixgbe_update_flash_X550() function that passes this buffer to > > ixgbe_host_interface_command(). > > Commit is correct, please configure your AI to look all the history of the > patch, where I explained that it was a 0 day issue.
Sorry about that. I did look over this myself, but I guess I must a have forgotten to look over the patch history at the time. ...
