> -----Original Message-----
> From: Intel-wired-lan <[email protected]> On Behalf
> Of Paul Greenwalt
> Sent: Wednesday, March 18, 2026 2:24 PM
> To: [email protected]
> Cc: Greenwalt, Paul <[email protected]>; Kitszel, Przemyslaw
> <[email protected]>
> Subject: [Intel-wired-lan] [PATCH iwl-net v1] ice: fix PHY config on
> media change with link-down-on-close
>
> Commit 1a3571b5938c ("ice: restore PHY settings on media insertion")
> introduced separate flows for setting PHY configuration on media
> present: ice_configure_phy() when link-down-on-close is disabled, and
> ice_force_phys_link_state() when enabled. The latter incorrectly uses
> the previous configuration even after module change, causing link
> issues such as wrong speed or no link.
>
> Unify PHY configuration into a single ice_phy_cfg() function with a
> link_en parameter, ensuring PHY capabilities are always fetched fresh
> from hardware.
>
> Fixes: 1a3571b5938c ("ice: restore PHY settings on media insertion")
> Reviewed-by: Przemek Kitszel <[email protected]>
> Signed-off-by: Paul Greenwalt <[email protected]>
> ---
> drivers/net/ethernet/intel/ice/ice_main.c | 121 +++++----------------
> -
> 1 file changed, 27 insertions(+), 94 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_main.c
> b/drivers/net/ethernet/intel/ice/ice_main.c
> index ebf48feffb30..512e55e974e2 100644
> --- a/drivers/net/ethernet/intel/ice/ice_main.c
> +++ b/drivers/net/ethernet/intel/ice/ice_main.c
> @@ -1922,82 +1922,6 @@ static void ice_handle_mdd_event(struct ice_pf
> *pf)
> ice_print_vfs_mdd_events(pf);
> }
>
...
> --
> 2.52.0
Reviewed-by: Aleksandr Loktionov <[email protected]>
