> -----Original Message-----
> From: Intel-wired-lan <[email protected]> On Behalf
> Of Larysa Zaremba
> Sent: Monday, March 23, 2026 6:41 PM
> To: [email protected]; Nguyen, Anthony L
> <[email protected]>
> Cc: Lobakin, Aleksander <[email protected]>; Samudrala,
> Sridhar <[email protected]>; Singhai, Anjali
> <[email protected]>; Michal Swiatkowski
> <[email protected]>; Zaremba, Larysa
> <[email protected]>; Fijalkowski, Maciej
> <[email protected]>; Tantilov, Emil S
> <[email protected]>; Chittim, Madhu <[email protected]>;
> Hay, Joshua A <[email protected]>; Keller, Jacob E
> <[email protected]>; Shanmugam, Jayaprakash
> <[email protected]>; Jiri Pirko <[email protected]>;
> David S. Miller <[email protected]>; Eric Dumazet
> <[email protected]>; Jakub Kicinski <[email protected]>; Paolo Abeni
> <[email protected]>; Simon Horman <[email protected]>; Jonathan Corbet
> <[email protected]>; Richard Cochran <[email protected]>; Kitszel,
> Przemyslaw <[email protected]>; Andrew Lunn
> <[email protected]>; [email protected]; linux-
> [email protected]; [email protected]
> Subject: [Intel-wired-lan] [PATCH iwl-next v6 06/14] idpf: remove
> 'vport_params_reqd' field
>
> From: Pavan Kumar Linga <[email protected]>
>
> While sending a create vport message to the device control plane, a
> create vport virtchnl message is prepared with all the required info
> to initialize the vport. This info is stored in the adapter struct but
> never used thereafter. So, remove the said field.
>
> Signed-off-by: Pavan Kumar Linga <[email protected]>
> Reviewed-by: Maciej Fijalkowski <[email protected]>
> Reviewed-by: Madhu Chittim <[email protected]>
> Signed-off-by: Larysa Zaremba <[email protected]>
> Tested-by: Samuel Salin <[email protected]>
> Signed-off-by: Tony Nguyen <[email protected]>
> ---
> drivers/net/ethernet/intel/idpf/idpf.h | 2 --
> drivers/net/ethernet/intel/idpf/idpf_lib.c | 2 --
> .../net/ethernet/intel/idpf/idpf_virtchnl.c | 30 +++++++-----------
> -
> 3 files changed, 10 insertions(+), 24 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/idpf/idpf.h
> b/drivers/net/ethernet/intel/idpf/idpf.h
> index fe6ca5fcc5e3..e717f8097d23 100644
> --- a/drivers/net/ethernet/intel/idpf/idpf.h
> +++ b/drivers/net/ethernet/intel/idpf/idpf.h
> @@ -638,7 +638,6 @@ struct idpf_vc_xn_manager;
> * @avail_queues: Device given queue limits
> * @vports: Array to store vports created by the driver
> * @netdevs: Associated Vport netdevs
> - * @vport_params_reqd: Vport params requested
> * @vport_params_recvd: Vport params received
> * @vport_ids: Array of device given vport identifiers
> * @singleq_pt_lkup: Lookup table for singleq RX ptypes @@ -697,7
> +696,6 @@ struct idpf_adapter {
> struct idpf_avail_queue_info avail_queues;
> struct idpf_vport **vports;
> struct net_device **netdevs;
> - struct virtchnl2_create_vport **vport_params_reqd;
> struct virtchnl2_create_vport **vport_params_recvd;
> u32 *vport_ids;
>
> diff --git a/drivers/net/ethernet/intel/idpf/idpf_lib.c
> b/drivers/net/ethernet/intel/idpf/idpf_lib.c
> index cf966fe6c759..d88ca59edf97 100644
> --- a/drivers/net/ethernet/intel/idpf/idpf_lib.c
> +++ b/drivers/net/ethernet/intel/idpf/idpf_lib.c
> @@ -1109,8 +1109,6 @@ static void idpf_vport_rel(struct idpf_vport
> *vport)
>
> kfree(adapter->vport_params_recvd[idx]);
> adapter->vport_params_recvd[idx] = NULL;
> - kfree(adapter->vport_params_reqd[idx]);
> - adapter->vport_params_reqd[idx] = NULL;
>
> kfree(vport);
> adapter->num_alloc_vports--;
> diff --git a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c
> b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c
> index d5a877e1fef8..6e6aa38654f6 100644
> --- a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c
> +++ b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c
> @@ -1555,14 +1555,10 @@ int idpf_send_create_vport_msg(struct
> idpf_adapter *adapter,
> ssize_t reply_sz;
>
> buf_size = sizeof(struct virtchnl2_create_vport);
...
>
> adapter->vport_ids = kcalloc(num_max_vports, sizeof(u32),
> GFP_KERNEL);
> if (!adapter->vport_ids)
> --
> 2.47.0
Reviewed-by: Aleksandr Loktionov <[email protected]>
