On Mon, May 04, 2026 at 04:53:12PM -0700, Jacob Keller wrote: > On 4/28/2026 12:06 AM, Michal Swiatkowski wrote: > > The hardware is capable of calculating checksum for IPV6 packets with > > extension header. To not drop such packets switch from IP/IPV6 checksum > > to HW_CSUM. > > > > HW_CSUM is also used in previous generation (i40e). > > > > Previously HW_CSUM was used to indicate that hardware supports general > > checksum. Drop it assuming that if the hardware supports it, it is used. > > > > Disabling offload for E830 in case of TSO isn't needed anymore as the > > check for TSO is done in Tx path just before preparation of the special > > GCS descriptor. > > > > The commit from Fixes didn't introduce a bug, it just shown that the > > driver is doing sth wrong with the checksum features. > > > > Suggested-by: Jakub Ramaseuski <[email protected]> > > Reviewed-by: Przemek Kitszel <[email protected]> > > Fixes: 04c20a9356f2 ("net: skip offload for NETIF_F_IPV6_CSUM if ipv6 > > header contains extension") > > Signed-off-by: Michal Swiatkowski <[email protected]> > > --- > Am I correct in thinking that this supersedes (really, properly fixes) > the patch "ice: enable NETIF_F_HW_CSUM for GSO packets" at > https://patchwork.ozlabs.org/project/intel-wired-lan/patch/[email protected]/ > ? > > Thanks, > Jake
Yes, exactly. I think I linked it in cover letter, but maybe I should do it also here. Thanks
