> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of > Aleksandr Loktionov > Sent: 27 March 2026 12:53 > To: [email protected]; Nguyen, Anthony L > <[email protected]>; Loktionov, Aleksandr > <[email protected]> > Cc: [email protected]; Czapnik, Lukasz <[email protected]> > Subject: [Intel-wired-lan] [PATCH iwl-next] ice: fix AQ error code comparison > in ice_set_pauseparam() > > From: Lukasz Czapnik <[email protected]> > > Fix unreachable code: the conditionals in ice_set_pauseparam() used the > bitwise-AND operator suggesting aq_failures is a bitmap, but it is actually > an enum, making the third condition logically unreachable. > > Replace the if-else ladder with a switch statement. Also move the > aq_failures initialization to the variable declaration and remove the > redundant zeroing from ice_set_fc(). > > Fixes: fcea6f3da546 ("ice: Add stats and ethtool support") > Signed-off-by: Lukasz Czapnik <[email protected]> > Signed-off-by: Aleksandr Loktionov <[email protected]> > --- > > drivers/net/ethernet/intel/ice/ice_common.c | 1 - > drivers/net/ethernet/intel/ice/ice_ethtool.c | 12 ++++++++---- > 2 files changed, 8 insertions(+), 5 deletions(-) >
Tested-by: Rinitha S <[email protected]> (A Contingent worker at Intel)
