> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of Jacob > Keller > Sent: 14 May 2026 22:25 > To: Nguyen, Anthony L <[email protected]>; Kitszel, Przemyslaw > <[email protected]>; Michal Wilczynski > <[email protected]> > Cc: [email protected]; [email protected]; Keller, Jacob E > <[email protected]> > Subject: [Intel-wired-lan] [PATCH iwl-net] ice: add missing xa_destroy for > sched_node_ids > > Commit 16dfa49406bc ("ice: Introduce new parameters in ice_sched_node") added > a sched_node_ids xarray to the port info structure, but never called > xa_destroy on it. > > Since xarrays can allocate internal memory, this can result in a memory leak > even if every element in the xarray has been removed. > > Add a call to xa_destroy the structure during ice_deinit_hw(), and one to the > unrolling cleanup path during errors in ice_init_hw(). While here, remove the > overly verbose comment explaining the nature of the sched_node_ids xarray. > > This was caught by Sashiko during development of unrelated code. > > Fixes: 16dfa49406bc ("ice: Introduce new parameters in ice_sched_node") > Signed-off-by: Jacob Keller <[email protected]> > --- > drivers/net/ethernet/intel/ice/ice_common.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) >
Tested-by: Rinitha S <[email protected]> (A Contingent worker at Intel)
