> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of > Jedrzej Jagielski > Sent: 02 July 2026 14:46 > To: [email protected] > Cc: Nguyen, Anthony L <[email protected]>; [email protected]; > Jagielski, Jedrzej <[email protected]>; Loktionov, Aleksandr > <[email protected]> > Subject: [Intel-wired-lan] [PATCH iwl-next v1 4/6] ixgbe: E610: re-enable LSE > unconditionally > > ixgbe_aci_get_link_info() currently allows to [en/dis]able LSE by @ena_lse > param. This isn't proper approach as this function objective is completely > different than toggling LSE feature. Creating such parameter was probably > dictated by the fact the flag corresponding for LSE enablement was placed > within the ACI command used by the function. > > LSE should not be switched off while the ixgbe driver is running. > Current driver behavior doesn't provide such possibility for the user. > > Enable LSE by default whenever 0x0607 ACI command is sent. Such change > corresponds to the fact that FW disables LSE whenever new event is triggered. > ixgbe_aci_get_link_info() is a part of routine handling LSE events, so it > ensures that LSE remain enabled. > > Remove wrappers utilizing @ena_lse param to [en/dis]able LSE as they are no > longer valid. > > Reviewed-by: Aleksandr Loktionov <[email protected]> > Signed-off-by: Jedrzej Jagielski <[email protected]> > --- > drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c | 25 ++++--------------- > drivers/net/ethernet/intel/ixgbe/ixgbe_e610.h | 3 +-- > .../net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 2 +- > drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 23 +---------------- > 4 files changed, 8 insertions(+), 45 deletions(-) >
Tested-by: Rinitha S <[email protected]> (A Contingent worker at Intel)
