On Tue, Sep 15, 2026 at 02:55:28PM +0200, Aleksandr Loktionov wrote: > From: Konrad Knitter <[email protected]> > > Disabling autonegotiation was silently ignored when autoneg had not yet > completed (ICE_AQ_AN_COMPLETED was not set), leaving the configuration > unchanged with no error. This could prevent link from forming if the > link partner requires non-autoneg mode. > > Extend the condition to also allow disabling autoneg when the link > partner reports no AN ability (ICE_AQ_LP_AN_ABILITY clear). Gate the > ICE_AQ_LP_AN_ABILITY check on the link being up so that stale or > zeroed an_info when link is down does not produce a false positive. > Introduce the helper ice_autoneg_disable_allowed() to make the check > explicit. > > Fixes: f1a4a66d2310 ("ice: fix set pause param autoneg check") > Signed-off-by: Konrad Knitter <[email protected]> > Signed-off-by: Aleksandr Loktionov <[email protected]>
Reviewed-by: Simon Horman <[email protected]>
