Dear Linkui,
Thank you for your patch.
Am 17.09.26 um 08:54 schrieb Linkui Xiao:
From: Linkui Xiao <[email protected]>
IXGBE_DEVLINK_RELOAD_TIMEOUT_SEC is misleading: the value counts 0.5 s
poll iterations, not seconds, as the comment right above it already
explains. Rename it to IXGBE_DEVLINK_RELOAD_MAX_ITER, which says what the
value actually is.
Reviewed-by: Przemek Kitszel <[email protected]>
Signed-off-by: Linkui Xiao <[email protected]>
---
drivers/net/ethernet/intel/ixgbe/devlink/devlink.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/ixgbe/devlink/devlink.c
b/drivers/net/ethernet/intel/ixgbe/devlink/devlink.c
index 781f13240a0d..15b14c5a7c4e 100644
--- a/drivers/net/ethernet/intel/ixgbe/devlink/devlink.c
+++ b/drivers/net/ethernet/intel/ixgbe/devlink/devlink.c
@@ -430,7 +430,7 @@ static int ixgbe_devlink_reload_empr_start(struct devlink
*devlink,
}
/*Wait for 10 sec with 0.5 sec tic. EMPR takes no less than half of a sec */
-#define IXGBE_DEVLINK_RELOAD_TIMEOUT_SEC 20
+#define IXGBE_DEVLINK_RELOAD_MAX_ITER 20
/**
* ixgbe_devlink_reload_empr_finish - finishes EMP reset
@@ -464,7 +464,7 @@ static int ixgbe_devlink_reload_empr_finish(struct devlink
*devlink,
fwsm = IXGBE_READ_REG(hw, IXGBE_FWSM(hw));
- if (i++ >= IXGBE_DEVLINK_RELOAD_TIMEOUT_SEC)
+ if (i++ >= IXGBE_DEVLINK_RELOAD_MAX_ITER)
return -ETIME;
} while (!(fwsm & IXGBE_FWSM_FW_VAL_BIT));
Reviewed-by: Paul Menzel <[email protected]>
Kind regards,
Paul
