Hi Aleksandr,

kernel test robot noticed the following build errors:

[auto build test ERROR on tnguy-next-queue/dev-queue]
[also build test ERROR on tnguy-net-queue/dev-queue linus/master v7.3-rc3 
next-20260916]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    
https://github.com/intel-lab-lkp/linux/commits/Aleksandr-Loktionov/From-Aleksandr-Loktionov-aleksandr-loktionov-intel-com/20260917-114312
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue.git 
dev-queue
patch link:    
https://lore.kernel.org/r/20260917094312.1567881-3-aleksandr.loktionov%40intel.com
patch subject: From: Aleksandr Loktionov <[email protected]>
config: x86_64-rhel-9.4 
(https://download.01.org/0day-ci/archive/20260918/[email protected]/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): 
(https://download.01.org/0day-ci/archive/20260918/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: 
https://lore.kernel.org/oe-kbuild-all/[email protected]/

All errors (new ones prefixed by >>):

   drivers/net/ethernet/intel/ice/ice_fw_update.c: In function 
'ice_send_component_table':
>> drivers/net/ethernet/intel/ice/ice_fw_update.c:255:51: error: 'ICE_F_EROT' 
>> undeclared (first use in this function)
     255 |                 if (!ice_is_feature_supported(pf, ICE_F_EROT)) {
         |                                                   ^~~~~~~~~~
   drivers/net/ethernet/intel/ice/ice_fw_update.c:255:51: note: each undeclared 
identifier is reported only once for each function it appears in
   drivers/net/ethernet/intel/ice/ice_fw_update.c: In function 
'ice_has_erot_incomplete':
   drivers/net/ethernet/intel/ice/ice_fw_update.c:680:49: error: 'ICE_F_EROT' 
undeclared (first use in this function)
     680 |         if (!ice_is_feature_supported(priv->pf, ICE_F_EROT))
         |                                                 ^~~~~~~~~~


vim +/ICE_F_EROT +255 drivers/net/ethernet/intel/ice/ice_fw_update.c

   213  
   214  /**
   215   * ice_send_component_table - Send PLDM component table to firmware
   216   * @context: PLDM fw update structure
   217   * @component: the component to process
   218   * @transfer_flag: relative transfer order of this component
   219   *
   220   * Read relevant data from the component and forward it to the device
   221   * firmware. Check the response to determine if the firmware indicates 
that
   222   * the update can proceed.
   223   *
   224   * This function sends AdminQ commands related to the NVM, and assumes 
that
   225   * the NVM resource has been acquired.
   226   *
   227   * Returns: zero on success, or a negative error code on failure.
   228   */
   229  static int
   230  ice_send_component_table(struct pldmfw *context, struct 
pldmfw_component *component,
   231                           u8 transfer_flag)
   232  {
   233          struct ice_fwu_priv *priv = container_of(context, struct 
ice_fwu_priv, context);
   234          struct netlink_ext_ack *extack = priv->extack;
   235          struct ice_aqc_nvm_comp_tbl *comp_tbl;
   236          u8 comp_response, comp_response_code;
   237          struct device *dev = context->dev;
   238          struct ice_pf *pf = priv->pf;
   239          struct ice_hw *hw = &pf->hw;
   240          size_t length;
   241          u8 comp_bit;
   242          int status;
   243  
   244          switch (component->identifier) {
   245          case NVM_COMP_ID_OROM:
   246                  comp_bit = ICE_FWU_COMP_OROM;
   247                  break;
   248          case NVM_COMP_ID_NVM:
   249                  comp_bit = ICE_FWU_COMP_NVM;
   250                  break;
   251          case NVM_COMP_ID_NETLIST:
   252                  comp_bit = ICE_FWU_COMP_NETLIST;
   253                  break;
   254          case NVM_COMP_ID_MANIFEST:
 > 255                  if (!ice_is_feature_supported(pf, ICE_F_EROT)) {
   256                          dev_err(dev, "Unable to update due to a 
firmware component with unknown ID %u\n",
   257                                  component->identifier);
   258                          NL_SET_ERR_MSG_MOD(extack,
   259                                             "Unable to update due to 
unknown firmware component");
   260                          return -EOPNOTSUPP;
   261                  }
   262                  comp_bit = ICE_FWU_COMP_MANIFEST;
   263                  break;
   264          default:
   265                  dev_err(dev, "Unable to update due to a firmware 
component with unknown ID %u\n",
   266                          component->identifier);
   267                  NL_SET_ERR_MSG_MOD(extack, "Unable to update due to 
unknown firmware component");
   268                  return -EOPNOTSUPP;
   269          }
   270  
   271          if (priv->seen_components & comp_bit) {
   272                  dev_err(dev, "Duplicate component in PLDM image: 
component ID 0x%02x\n",
   273                          component->identifier);
   274                  NL_SET_ERR_MSG_MOD(extack, "Duplicate component in PLDM 
image");
   275                  return -EOPNOTSUPP;
   276          }
   277          priv->seen_components |= comp_bit;
   278  
   279          length = struct_size(comp_tbl, cvs, component->version_len);
   280          comp_tbl = kzalloc(length, GFP_KERNEL);
   281          if (!comp_tbl)
   282                  return -ENOMEM;
   283  
   284          comp_tbl->comp_class = cpu_to_le16(component->classification);
   285          comp_tbl->comp_id = cpu_to_le16(component->identifier);
   286          comp_tbl->comp_class_idx = FWU_COMP_CLASS_IDX_NOT_USE;
   287          comp_tbl->comp_cmp_stamp = 
cpu_to_le32(component->comparison_stamp);
   288          comp_tbl->cvs_type = component->version_type;
   289          comp_tbl->cvs_len = component->version_len;
   290          memcpy(comp_tbl->cvs, component->version_string, 
component->version_len);
   291  
   292          dev_dbg(dev, "Sending component table to firmware:\n");
   293  
   294          status = ice_nvm_pass_component_tbl(hw, (u8 *)comp_tbl, length,
   295                                              transfer_flag, 
&comp_response,
   296                                              &comp_response_code, NULL);
   297  
   298          kfree(comp_tbl);
   299  
   300          if (status) {
   301                  dev_err(dev, "Failed to transfer component table to 
firmware, err %d aq_err %s\n",
   302                          status, 
libie_aq_str(hw->adminq.sq_last_status));
   303                  NL_SET_ERR_MSG_MOD(extack, "Failed to transfer 
component table to firmware");
   304                  return -EIO;
   305          }
   306  
   307          return ice_check_component_response(pf, component->identifier, 
comp_response,
   308                                              comp_response_code, extack);
   309  }
   310  

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Reply via email to