> -----Original Message----- > From: Intel-wired-lan <[email protected]> On Behalf Of > Pengpeng Hou > Sent: Saturday, August 15, 2026 6:57 AM > To: Nguyen, Anthony L <[email protected]>; Kitszel, Przemyslaw > <[email protected]> > Cc: Pengpeng Hou <[email protected]>; Jagielski, Jedrzej > <[email protected]>; Loktionov, Aleksandr > <[email protected]>; Andrew Lunn <[email protected]>; David > S. Miller <[email protected]>; Eric Dumazet <[email protected]>; Jakub > Kicinski <[email protected]>; Paolo Abeni <[email protected]>; Richard Cochran > <[email protected]>; Keller, Jacob E <[email protected]>; > Kubalewski, Arkadiusz <[email protected]>; Karol Kolacinski > <[email protected]>; Temerkhanov, Sergey > <[email protected]>; Michal Michalik <[email protected]>; > Simon Horman <[email protected]>; [email protected]; > [email protected]; [email protected] > Subject: [Intel-wired-lan] [PATCH iwl-net v3] ice: propagate ETH56G deskew > poll failures > > ice_ptp_calc_deskew_eth56g() ignores the return value of read_poll_timeout(). > If register reads succeed but the DESKEW valid bit never appears, the timeout > is treated as success. If a register read fails, the poll condition can also > inspect deskew_i before a successful read and continue polling instead of > stopping on the hard error. The function then returns an int error through > its u32 deskew return type. > > Return the deskew value through an output parameter. Stop polling when either > the read fails or the valid bit appears, then propagate the register error or > the poll timeout separately before calculating and applying the deskew value. > > Fixes: 7cab44f1c35f ("ice: Introduce ETH56G PHY model for E825C products") > > Assisted-by: Codex:gpt-5 > Signed-off-by: Pengpeng Hou <[email protected]> > --- > Changes since v2: > https://lore.kernel.org/all/[email protected]/ > - capture and propagate the read_poll_timeout() result > - stop the poll immediately on a register read error > - initialize deskew_i before it is used by the poll condition > - do not carry the v2 Reviewed-by because the poll logic changed > > drivers/net/ethernet/intel/ice/ice_ptp_hw.c | 42 ++++++++++++++++++---------- > 1 file changed, 28 insertions(+), 14 deletions(-)
Tested-by: Alexander Nowlin <[email protected]>
