[Cc: +Mark Pearson for Lenovo to maybe fix firmware to support K1]
Dear Dima,
Thank you for your patch.
Am 12.10.26 um 23:41 schrieb Dima Ruinskiy:
On some Lenovo laptops performance issues were reported with K1 enabled.
I’d make one commit per device, so the device can be mentioned in the
summary/title, and it can be reverted more easily. It also helps
reverting commits in case of problems for just one device. Should you
stay with one commit, please at least mention the devices in the commit
message.
Commit messages should also be self-contained, so describing the
performance issue would be great. Having the firmware versions directly
in the commit message would also help me.
Add them to the list of systems where K1 is disabled by default.
Cc: [email protected]
Fixes: 578294b8b60d ("e1000e: Reconfigure PLL clock gate timeout and re-enable K1 on
Meteor Lake")
Reported-by: Christoph Groth <[email protected]>
Link: https://lore.kernel.org/intel-wired-lan/[email protected]/
Reported-by: ghrafn <[email protected]>
Link:
https://lore.kernel.org/intel-wired-lan/_kB6DUeC6oOmJnK0FobVVJHADewewO3wzeFw_GrempgMu6s5CUwHpkT16Bwn8tXRq0k_CN4b2NY6API37M6mVciEpH6DKbTqK7f13KMpmgI=@proton.me/
Signed-off-by: Dima Ruinskiy <[email protected]>
---
drivers/net/ethernet/intel/e1000e/netdev.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c
b/drivers/net/ethernet/intel/e1000e/netdev.c
index 834a5b8883df..35c729368684 100644
--- a/drivers/net/ethernet/intel/e1000e/netdev.c
+++ b/drivers/net/ethernet/intel/e1000e/netdev.c
@@ -74,6 +74,20 @@ static const struct dmi_system_id disable_k1_list[] = {
DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad P14s Gen 5"),
},
},
+ {
+ .ident = "Lenovo ThinkPad P14s Gen 6",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+ DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad P14s Gen 6"),
+ },
+ },
+ {
+ .ident = "Lenovo ThinkPad T14 Gen 6",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+ DMI_MATCH(DMI_PRODUCT_VERSION, "ThinkPad T14 Gen 6"),
+ },
+ },
{}
};
The diff looks good. With my comments addressed, please feel free to add:
Reviewed-by: Paul Menzel <[email protected]>
Kind regards,
Paul
PS: As far as I can see, it’s not logged, when K1 is disabled by the
quirk list.
