Hi Marcus, > Not good enough it seems :-( I'll get there... ;-)
> Some comments: > - Please always start with tabs, you used spaces to begin lines. done. > - TSRMLS_FETCH() is a variable declaration, so it cannot be used inside a > function. If I wipe TSRMLS_FETCH() out, I get this error: /usr/src/zend2/php-src/Zend/zend.c:234: `tsrm_ls' undeclared (first use in this function) So I kept it. > - Still you haven't checked whether or not the function to_string() is > available. I checked it with get_method, but I don't know how to call a function (internal, user or overloaded) using the zend_function union. So I check with "get_method" but still call with "call_user_function" when the union has the type=ZEND_USER_FUNCTION. I don't know what to do if type=ZEND_INTERNAL_FUNCTION or type=ZEND_OVERLOADED_FUNCTION, so I just do the default behavior. Plz, if you could help on this... Attached another patch. Cristiano Duarte "Marcus BöRger" <[EMAIL PROTECTED]> escreveu na mensagem news:[EMAIL PROTECTED] > Hello Cristiano, > > Sunday, August 3, 2003, 9:54:55 PM, you wrote: > > CD> I read README.SUBMITING_PATCH and attached the patch as specified. > > Not good enough it seems :-( > > Some comments: > - Please always start with tabs, you used spaces to begin lines. > - TSRMLS_FETCH() is a variable declaration, so it cannot be used inside a > function. > - Still you haven't checked whether or not the function to_string() is > available. > > > > > -- > Best regards, > Marcus mailto:[EMAIL PROTECTED] > begin 666 to_string.patch M/R!P:' M<W)C+UIE;F1%;F=I;F4Q"C\@<&AP+7-R8R]P:'!?=&5S=%]R97-U M;'1S7S(P,#,P.# [EMAIL PROTECTED]'AT"DEN9&5X.B!P:' M<W)C+UIE;F0O>F5N M9"YC"CT]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T] M/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T*4D-3(&9I;&4Z("]R97!O<VET M;W)Y+UIE;F1%;F=I;F4R+WIE;F0N8RQV"G)E=')I979I;F<@<F5V:7-I;VX@ M,2XR-#,*9&EF9B M=2 M<C$N,C0S('IE;F0N8PHM+2T@<&AP+7-R8R]:96YD M+WIE;F0N8PDS,"!*=6P@,C P,R Q-CHQ,SHU,B M,# P, DQ+C(T,PHK*RL@ M<&AP+7-R8R]:96YD+WIE;F0N8PDS($%U9R R,# S(#(R.C T.C V("TP,# P M"D! ("TR,[EMAIL PROTECTED]" K,C(X+#,W($! "B )"0D)5%-234Q37T9%5$-(*"D["B ) M"0D)97AP<BT^=F%L=64N;V)J+FAA;F1L97)S+3YC87-T7V]B:F5C="AE>'!R M+"!E>'!R7V-O<'DL($E37U-44DE.1RP@,"!44U)-3%-?0T,I.PH@"0D)?2!E M;'-E('L*+0D)"0EE>'!R7V-O<'DM/G9A;'5E+G-T<BYV86P@/2 H8VAA<B J M*2!E;6%L;&]C*'-I>[EMAIL PROTECTED])J96-T(&ED(",B*2TQ("[EMAIL PROTECTED] M2%]/1E],3TY'*3L*+0D)"0EE>'!R7V-O<'DM/G9A;'5E+G-T<BYL96X@/2!S M<')I;G1F*&5X<')?8V]P>2T^=F%L=64N<W1R+G9A;"P@(D]B:F5C="!I9" C M)6QD([EMAIL PROTECTED]&QO;F<I97AP<BT^=F%L=64N;V)J+FAA;F1L92D["BL)"0D):6YT M(&1E9F%U;'1?8F5H879I;W(@/2 Q.PHK"0D)"7IE;F1?9G5N8W1I;[EMAIL PROTECTED] M7W-T<FEN9U]M971H;V0["BL)"0D)5%-234Q37T9%5$-(*"D["BL)"0D)+R]C M:&5C:R!I9B!T;U]S=')I;F<@;65T:&]D(&5X:7-T<PHK"0D)"6EF("@H=&]? M<W1R:6YG7VUE=&AO9" ](%I?3T)*7TA!3D1,15)?4"AE>'!R+&=E=%]M971H M;V0I*&5X<'(L(")T;U]S=')I;F<B+" Y(%134DU,4U]#0RDI*2!["BL)"0D) M"7-W:71C:" H=&]?<W1R:6YG7VUE=&AO9"T^='EP92D@>PHK"0D)"0D)8V%S M92!:14Y$7TE.5$523D%,[EMAIL PROTECTED]"0D)"0D)8V%S92!:14Y$7T]6 M15),3T%$141?1E5.0U1)3TXZ"BL)"0D)"0D)8G)E86L["BL)"0D)"0EC87-E M(%I%3D1?55-%4E]&54Y#5$E/3CH**PD)"0D)"7L**PD)"0D)"0DO+R!T;U]S M=')I;F<@;65T:&]D(&5X:7-T<R!A;F0@:70G<R!A('5S97(@9G5N8W1I;VXL M(&QE="=S(&-A;&P@:70**PD)"0D)"0EZ=F%L("IF;[EMAIL PROTECTED])E='9A;#L* M*PD)"0D)"0E-04M%7U-41%]:5D%,*&9N86UE*3L**PD)"0D)"0E:5D%,7U-4 M4DE.1RAF;F%M92P@(G1O7W-T<FEN9R(L(#$I.PHK"0D)"0D)"6EF("AC86QL M7W5S97)?9G5N8W1I;[EMAIL PROTECTED],3"P@)F5X<'(L(&9N86UE+" F<F5T=F%L M+" P+"!.54Q,+" P+"!.54Q,(%134DU,4U]#0RD@/[EMAIL PROTECTED]@>PHK M"0D)"0D)"0EI9B H6E]465!%7U H<F5T=F%L*2 A/2!)4U]35%))3D<I('L* M*PD)"0D)"0D)"6-O;G9E<G1?=&]?<W1R:6YG*')E='9A;"D["BL)"0D)"0D) M"7T**PD)"0D)"0D)6E9!3%]35%))3D=,*&5X<')?8V]P>[EMAIL PROTECTED])604Q? M4"AR971V86PI+"!:7U-44DQ%3E]0*')E='9A;"DL(#$I.PHK"0D)"0D)"0EZ M=F%L7W!T<E]D=&]R*"9R971V86PI.PHK"0D)"0D)"0ED969A=6QT7V)E:&%V M:6]R(#T@,#L**PD)"0D)"0E]"BL)"0D)"0D)>G9A;%]P=')?9'1O<[EMAIL PROTECTED] M;64I.PHK"0D)"0D)?0HK"0D)"0E]"BL)"0D)?0HK"0D)"6EF("AD969A=6QT M7V)E:&%V:6]R*2!["BL)"0D)"5I?4U125D%,7U H97AP<E]C;W!Y*2 ]("AC M:&%R("HI(&5M86QL;V,H<VEZ96]F*")/8FIE8W0@:60@(R([EMAIL PROTECTED] M3$5.1U1(7T]&7TQ/3D<I.PHK"0D)"0E:7U-44DQ%3E]0*&5X<')?8V]P>2D@ M/2!S<')I;G1F*%I?4U125D%,7U H97AP<E]C;W!Y*2P@(D]B:F5C="!I9" C M)6QD([EMAIL PROTECTED]&QO;F<I6E]/0DI?2$%.1$Q%7U H97AP<BDI.PHK"0D)"7T*( D) M"7T*("-I9B P"B )"0DO*B!&[EMAIL PROTECTED]&AI<R!M:6=H="!B<F5A:R!"0R!F 2;W(@<V]M92!P96]P;&[EMAIL PROTECTED] ` end -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
