On Tue, 17 Feb 2004, Andi Gutmans wrote:
>At 11:36 AM 2/17/2004 +0200, Jani Taskinen wrote:
>
>> >
>> >I don't understand. Why fix it in PHP 5 if you're suggesting to nuke the
>> >function? :)
>>
>> I was thinking backwards. Nevermind. So nuke in PHP5, fix in PHP4.
>
>Yeah I agree. We should commit the fix in PHP 4 and nuke in PHP 5.
>
>
>> >> And change the extensions that use the register_list_destructors()
>> macro
>> >> to use the _ex() function.
>> >
>> >That can't be done. The callback prototypes are different.
>>
>> Either I'm not getting it or you misunderstood. I meant that the
>> one extension still in HEAD that uses zend_register_list_destructors()
>> would be fixed to use the zend_register_list_destructors_ex() function.
>> (kinda have to, if the former is nuked? :)
>
>That's fine. I thought you meant to make register_list_destructors() call
>register_list_destructors_ex().
It seems that nuking is out of question and not very good idea after all. ;)
Using zend_register_list_destructors() (or the macro, register_list_destructors),
might be valid in some cases and the real bug is only in the
zend_fetch_list_dtor_id()
function which really should ignore the 'unnamed resources'.
See ext/soap for more..
--Jani
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
