Hi Ilija, 1. I was confused by the vote announcement email about what "block statements" meant - https://github.com/php/php-src/pull/5371#discussion_r415079802
> Thus I have decided to move block expressions to a separate RFC. This is clarified in https://wiki.php.net/rfc/match_expression#blocks > **For the time being using blocks in match expressions that use the return > value in any way results in a compilation error:** (I personally agree with that change for this RFC introducing `match`) 2. As Dan Ackroyd mentioned, https://wiki.php.net/rfc/howto mentions: > When discussion ends, and a minimum period of two weeks has passed since you > mailed internals@lists.php.net in step 4, > consider one day heads up mail on the mailing list and then you can move your > RFC to “Voting” status. Other people may read the guidelines differently from me, and I've made small mistakes with the process in the past due to not remembering everything in the howto. (and they're guidelines instead of rules) In the future, I'd recommend: i. After finalizing the changes to the RFC and before starting the vote, email out a summary of what changed on the RFC discussion thread itself (https://externals.io/message/109590 "[DISCUSSION] Match expression") ii. Consider waiting at least 24 hours before starting the vote, extending it if you made more changes to the RFC or implementation. This would give voters a clearer idea of what was being voted on, and give people time to point out issues/blockers/new questions with the new RFC/implementation (if needed). P.S. Although it's obvious voting has started, and some other RFCs kept the title "Proposed Voting Choices", https://wiki.php.net/rfc/match_expression#proposed_voting_choices could be renamed from "Proposed Voting Choices" to "Vote" Thanks, - Tyson -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
