On Tue, 16 Nov 2021 at 22:21, Sara Golemon <poll...@php.net> wrote: > 1. Do you have code you're responsible for which uses dynamic properties so > broadly that adding this attribute is a burden? > 2. Do you know of real code in widespread use which uses dynamic properties > so broadly that adding this attribute is a burden? > > All I see being bandied about are hypotheticals.
That's fair, and tbh mine has been the hypothetical legacy code... reading all the discussion, I think I've been convinced it's worth the change, especially as this is a deprecation a few versions before anything actually breaks. I think my original negative opinion was more of a "oh, not more stuff to change", especially while I know of a few people now fixing all of the issues that "passing null to non-nullable arguments of internal functions" is causing; with trim, strlen, strpos, etc... https://externals.io/message/116076 And even more off-topic... well done everyone for on PHP Foundation, and thank you Nikita for everything you have done (you really have accomplished a lot). Craig
