Ahhh okay that explains where this change is coming from. Thanks a lot, Dan!
I wonder if this side effect ("all dependencies are iterated also
during "make install") is intentional.
Maybe Niki can chime in on GitHub; I'll ping him there, as well as the
original author.
Thanks a lot!
David
P.S. regarding your earlier comment on the '-include' directive - that
allows the actual file you're specifying there to be missing; not any
file names listed inside it - the purpose is to optionally let
generic/templated Makefiles specify a file that lists additional
includes, but making that file itself optional.
On Thu, Dec 9, 2021 at 8:41 PM Dan Ackroyd <[email protected]> wrote:
>
> On Thu, 9 Dec 2021 at 19:28, Dan Ackroyd <[email protected]> wrote:
> > > Is this intentional? If so, could someone explain the purpose of the
> > > change?
> >
> > Probably to make the build process less flaky, by explicitly checking
> > dependencies, so that there are fewer instances of "stuffs not
> > working.....I guess I'll do a make clean and see if that helps".
> >
>
> And of course I find the commit just after sending previous email:
>
> commit -
> https://github.com/php/php-src/commit/c4d508c2bc09860bfa15b7f520e0ba68425acfc1
> reasoning - https://github.com/php/php-src/pull/6693
>
> cheers
> Dan
> Ack
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: https://www.php.net/unsub.php
