Hi internals, I was told to ask for your feedback regarding the following PR I've opened: https://github.com/php/php-src/pull/11430.
The PR adds a $before_needle argument to strrchr() that allows returning part of the haystack before the occurrence of the needle. Similar functions such as strstr(), stristr() or its mb counterpart mb_strrchr() already have this option, strrchr() seems to be the only one without it. According to Jakub Zelenka, if no one objects, the PR can get merged. Best regards, Berislav