On Thu, 18 Jul 2024, 16:32 Ilija Tovilo, <tovilo.il...@gmail.com> wrote:
> Hi Christoph > > On Thu, Jul 18, 2024 at 2:09 PM Christoph M. Becker <cmbecke...@gmx.de> > wrote: > > > > So I suggest to sync CODEOWNERS for all active branches (and maybe even > > security branches). > > > > What do you think? > > I think back when it was introduced it wasn't clear (at least to me) > that PRs would request reviews based on the CODEOWNERS file of the > target branch, rather than the default branch. Given that's how it > works, syncing it in all active branches makes sense to me. > > Ilija > I think that nothing will help solve this issue but to write also some comment in that file on top to send updates to the earliest supported branch, and not the master branch only. We were resolving this in the past not so long ago: https://github.com/php/php-src/pull/13591 >
