Hi, On Mon, Jul 22, 2024 at 11:59 AM Jakub Zelenka <bu...@php.net> wrote:
> Hi, > > On Fri, Jul 19, 2024 at 6:42 PM Gina P. Banyard <intern...@gpb.moe> wrote: > >> Hello internals, >> >> I have opened the vote for the mega deprecation RFC: >> https://wiki.php.net/rfc/deprecations_php_true8_4 >> <https://wiki.php.net/rfc/deprecations_php_8_4> >> >> Reminder, each vote must be submitted individually. >> >> > > I voted no on those output handlers as there might be potentially better > solutions. The whole output stuff needs a closer look so I think we should > wait on this until the review is done. > I just had a bit closer look to output handler working and the text is actually not correct and does not exactly reflect how things works. Interestingly those two suggested deprecations have associated functionality that can be seen in the following example: https://3v4l.org/X91eu This simple example shows that returning false from the handler have a special behaviour that can be in no way replaced by throwing exception. What it does is that it flushes all buffers and does not trigger any error as far as I see. It also shows that output in the output handler is not actually always discarded and can be actually used to append text which might be actually useful functionality for some users. This is just finding from looking and testing things for around an hour and half of my time so I might missed other bits. I really think we should first try to properly understand how the whole output handling works before doing those sort of deprecations. The RFC should then contain all details about the edge cases so voters can do informed decision. I would suggest to take this part out and at least delay it till the next release. Apology for not taking look sooner but I have been pretty busy until now... Regards Jakub
