On Mon, 30 Jun 2025, youkidearitai wrote: > Hi, Internals > > I have just started add locale for grapheme_* functions. > https://wiki.php.net/rfc/grapheme_add_locale_for_case_insensitive > > Voting end is 2025-07-15 00:00:00 GMT.
Hi, I have voted no for now, as I don't think the RFC explains a various amount of situations: - How are locale string handled that don't exist (exception? silently ignored?) - What range of locales are allowed? Where would this list come from? - How do fallbacks of locales work? - Are locale variants handled? - Is it really wise to use strings for locales? - How are locale strenghts handled, such as the primary/secondary/tertiary modes of ICU — these influence the matchy-ness of characters. For all these situations, there should also be tests, but that's an implementation detail. cheers, Derick -- https://derickrethans.nl | https://xdebug.org | https://dram.io Author of Xdebug. Like it? Consider supporting me: https://xdebug.org/support mastodon: @derickr@phpc.social @xdebug@phpc.social
