> >> this essentially privileges the FPM SAPI, right at the > >> time that we're seeing more and more alternate SAPIs. (FrankenPHP, > >> Swoole, […] > >> > >> I just want to make sure we don't inadvertently lock in FPM as The Way > >> PHP Runs(tm) just at the time that it no longer is. > > > > > > I share this concern. > > The fpm binary should embed the cli if we go this way. Not the other way > > around. > > Same as frankenphp shipping also the cli, especially since it's been made > > easier in PHP 8.6. > > > I was actually thinking about this and it really makes more sense and also > better in terms of implementation as we will just do what FrankenPHP does.
Right, good point, I agree too, thanks! I opened a new PR that goes the other way around: https://github.com/php/php-src/pull/24192 I have also updated the RFC: https://wiki.php.net/rfc/single-binary-cli-fpm - `php` CLI is unchanged - `php-fpm` *always* includes `php` (and runs as CLI when run as `php` instead of `php-fpm`) - no need for a build option anymore - the diff is simpler - FPM aligns with FrankenPHP (both include the CLI) - No `--fpm` CLI option anymore, solves the objections raised previously in this thread That sounds much better indeed.
