Hi Sjoerd
On 30.10.26 10:55, Sjoerd Langkemper wrote:
I would like access to php-src in GitHub. I would like to merge my own
approved pull requests, and review other people's pull requests. I
have previously done some work on the curl extension and I think it
would be a good idea to register myself as code owner for that
extension, so that I can review merge requests related to curl.
There's a form to request access, but it gave an error since I already
have a PHP account (sjoerd). My GitHub username is Sjord.
Sorry for the long delay.
We had a short internal discourse and feel it might be a bit early. I
see you've opened more PRs recently, which is great. The majority of
those target master, for which the burden of merging is very small.
Git access makes most sense when you either:
* send lots of PRs to stable branches, for which the merge process is
more involved.
* can meaningfully review and merge PRs autonomously and with
confidence that changes are correct.
We already feel that we've given out git karma too early in the past.
When something is proposed and reviewed by two newer contributors, it's
very hard to have an overview of what happens in the codebase.
I haven't handled many of your PRs, so if there's somebody else who
might see things differently, feel free to have them reach out to me.
Ilija