Hi Jani,

You shouldn't patch zend_vm_gen.php.
The option --without-old-executor is reverted to --with-old-executor.
So people will be able to generate old executor too.

Other part probably should work, but as I said, I don't like generated files
in CVS (however we can generate them for release).

Thanks. Dmitry.

> -----Original Message-----
> From: Jani Taskinen [mailto:[EMAIL PROTECTED] 
> Sent: Friday, June 17, 2005 2:17 PM
> To: Sebastian Bergmann
> Cc: internals@lists.php.net
> Subject: Re: [PHP-DEV] Adding the generated files for 
> GOTO/SWITCH VM to CVS
> 
> 
> 
>      Here's a patch to get the multiple versions:
>      (totally untested!)
> 
>      http://www.php.net/~jani/patches/zend_multi_vm.patch
> 
>      I didn't want to change the generator that much, so
>      if you want to generate all, just run it 3 times.
>      Perhaps this could be a buildconf thing?
> 
>      --Jani
> 
> On Fri, 17 Jun 2005, Sebastian Bergmann wrote:
> 
> > It would be great (from a usability point) to add the 
> generated files 
> > for all three (CALL, GOTO, SWITCH) VM models to CVS as
> >
> >   zend_vm_opcodes_call.h
> >   zend_vm_execute_call.h
> >   zend_vm_opcodes_goto.h
> >   zend_vm_execute_goto.h
> >   zend_vm_opcodes_switch.h
> >   zend_vm_execute_switch.h
> >
> > and have the --with-zend-vm configure parameter choose the 
> right pair.
> >
> > This way it will be possible to build GOTO and SWITCH without a 
> > working PHP interpreter available. It would also be consistent with 
> > the "have all generated files in CVS" rule.
> >
> > To make things easier with this new setup the 
> zend_vm_gen.php script 
> > should be changed that it creates the above listed files by default.
> >
> >
> 
> -- 
> Donate @ http://pecl.php.net/wishlist.php/sniper
> 
> -- 
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
> 
> 

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to