On Sat, 2005-08-13 at 23:53, Sara Golemon wrote:
> > I really doubt this will change.
> > It would be a *huge* mess in the docs
> > and peoples scripts and brains
> > if we did change it--it wouldn't really
> > win anyone anything:
> >
> At the risk of someone taking this as a worthwhile idea:
>
> PHP_FUNCTION(strpos)
> {
> ...
> /* Swap needle and haystack if they appear to be backwards */
> if (needle_len > haystack_len) {
> char *t; int t_len;
> t = needle; needle = haystack; haystack = t;
> t_len = needle_len; needle_len = haystack_len; haystack_len = t_len;
> }
> ...
> }
That's not valid since it may be the case that both the needle and the
haystack were generated from user input over which you have no idea
about the values and can make no assumptions. it would be a complete
mess to get false positives because the reversal just happened to match.
Cheers,
Rob.
--
.------------------------------------------------------------.
| InterJinn Application Framework - http://www.interjinn.com |
:------------------------------------------------------------:
| An application and templating framework for PHP. Boasting |
| a powerful, scalable system for accessing system services |
| such as forms, properties, sessions, and caches. InterJinn |
| also provides an extremely flexible architecture for |
| creating re-usable components quickly and easily. |
`------------------------------------------------------------'
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
