On Sat, 16 Sep 2006, Dan Scott wrote:

> On 16/09/06, Ilia Alshanetsky <[EMAIL PROTECTED]> wrote:
> >
> > On 16-Sep-06, at 11:35 AM, Dan Scott wrote:
> >
> > > Minor: the general structure of the function names are
> > > <prefix>_<verb>_<noun>, so it would be more consistent if this was
> > > 'input_list_filters'.
> > >
> > > Overall: +1 (with bonus points if you go with <prefix>_<verb>_<noun>
> > > for the two identified cases)
> >
> > I for one think we should try to keep the names of something that
> > (hopefully) will be used often as short possible to reduce the likely
> > hood of typos.
> >
> > Ilia Alshanetsky
> 
> Agreed. input_id_filter() is shorter than input_name_to_filter(), and
> input_list_filters() is the same length as input_filters_list().

This function won't be used a lot, so a longer name is fine. I would go 
for input_get_filter_id() and input_list_filters().

regards,
Derick

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to