Pierre wrote:
On 10/23/06, Pierre <[EMAIL PROTECTED]> wrote:
Hello,
On 10/23/06, Ilia Alshanetsky <[EMAIL PROTECTED]> wrote:
> Use of mktime(0) and alike is improper use of the function, more over
> generally it can be traced to an undesired code behavior.
Which is? mktime(0) is just like mktime(24); if it is not the case,
there is a bug (it is the case). But I suppose you mean mktime(0,0,0,
0,0,0);?
However and for the clarity/sanitiy of this discussion mktime(0,0,0,
0,0,0) does not raise any error, mktime(); does.
To solve the only argument in favour of this error message, Derick
should simply remove the notice and add these three little line before
the arguments parsing:
if (ZEND_NUM_ARGS() == 0) {
RETURN_LONG((long)time(NULL));
}
To be exact:
if (NUM_ARGS()==0 && !gmt) { RETURN_LONG((long)time(NULL)); }
as gmmktime uses php_mktime as well, but in GMT mode.
Yes, I see no point in pushing this responsibility into the userland,
especially since its a BC break appearently.
regards,
Lukas
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
