That is still a binary compatibility break. Binary compatibility isn't just backwards, but also forwards within a major version. eg. if I build an extension against PHP 5.2.3 I expect it to also work in PHP 5.2.1 and it won't in this case if the extension is accessing this added element.
-Rasmus Dmitry Stogov wrote: > The size of global structure is important only during allocation (in > main.c). > The offsets of all old elements of the structure are still the same, because > I added new element in the end. > > Dmitry. > > >> -----Original Message----- >> From: Ilia Alshanetsky [mailto:[EMAIL PROTECTED] >> Sent: Tuesday, July 03, 2007 4:30 PM >> To: Dmitry Stogov >> Cc: internals@lists.php.net; Stanislav Malyshev >> Subject: [PHP-DEV] Re: [PHP-CVS] cvs: php-src /ext/standard >> basic_functions.c streamsfuncs.c streamsfuncs.h >> /ext/standard/tests/file include_userstream_001.phpt >> include_userstream_002.phpt /main main.c php_globals.h >> php_streams.h /main/streams str >> >> >> You are changing a global struct and it does not break BC, how does >> that work? >> >> Ilia >> >> -- >> PHP Internals - PHP Runtime Development Mailing List >> To unsubscribe, visit: http://www.php.net/unsub.php >> > -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php