You might have a point there; I'd assumed that CFLAGS made it through to php-config, but it doesn't look like they do.
It should be a simple matter to define them in php_config.h instead.

--Wez.

On Oct 16, 2007, at 6:16 PM, Stanislav Malyshev wrote:

Yes, the patch does that; it turns on LFS in the headers, which promotes the off_t and size_t types that are used by streams to the 64-bit versions. This is the one liner in configure.in. The other larger part of the patch is to make PHP functions capable of returning and accepting numbers that are too big to fit into a long.

I think it's better to do it in .h file and not CFLAGS (or both?) so that if somebody includes PHP headers they would always get the same result. This would prevent one from building incompatible module.

Is it guaranteed that once you have this define you would always get the same result on all builds (regardless of libc difference, etc.)?
--
Stanislav Malyshev, Zend Software Architect
[EMAIL PROTECTED]   http://www.zend.com/
(408)253-8829   MSN: [EMAIL PROTECTED]

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to